Replace deprecated JobIntentService with WorkManager #5742
Conversation
TacoTheDank
force-pushed
the
widgetUpdaterWorkManager
branch
from
d89c025
to
5146dc8
Compare
core/src/main/java/de/danoeh/antennapod/core/widget/WidgetUpdaterWorker.java
Outdated
Show resolved
Hide resolved
TacoTheDank
force-pushed
the
widgetUpdaterWorkManager
branch
from
5146dc8
to
d796a93
Compare
|
Why did the validation wrapper fail 🤔 Okay passed now. |
TacoTheDank
force-pushed
the
widgetUpdaterWorkManager
branch
from
d796a93
to
149a153
Compare
|
Thank you. |
|
Looks like this broke the widget. It can now sometimes get into a loop and update forever. Reverting this commit immediately fixes the problem. Looks like device-2022-04-22-230436.mp4 |
|
I didn't experience that at all 🤔. I will attempt to reproduce and solve this issue. Right now I'm at the end of my semester, so I'll have little time to test for the next week or so. What Android version was this recording shot on? |
Android 11 (LineageOS). I cannot reproduce in an emulator, unfortunately. But I can reproduce in both Nova Launcher and Lawnchair2. Hmmm... |
|
Re-installing the app fixed this. Maybe WorkManager somehow remembered old jobs and triggered them again and again. Not sure. Let's hope it does not come back. |
|
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/antennapod-2-6-release-notes/1964/1 |
|
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: |
JobIntentService is deprecated. WorkManager is its recommended replacement. I replaced it.
Why? Because JobIntentService has an infamous crashing bug on Android O (though that was fixed with a workaround). And it's also deprecated.
Tested on APIs 29 (physical device) and 22 (virtual device).
See these for WorkManager info.
Feel free to make any suggestions.