Add auto-complete to discovery country selection #6139
Conversation
| MaterialAutoCompleteTextView editText = (MaterialAutoCompleteTextView) textInput.getEditText(); | ||
| editText.setAdapter(dataAdapter); | ||
| if (countryCode.equals(ItunesTopListLoader.DISCOVER_HIDE_FAKE_COUNTRY_CODE)) { | ||
| editText.setText(countryCodeNames.get(previousCountryCode)); |
There was a problem hiding this comment.
Why do you store the previous code? It's only in a variable anyway, so it doesn't really help?
There was a problem hiding this comment.
I use this variable in order to restore country user previously selected when they uncheck "Hide" checkbox, and to show previously selected country in drop-down list instead of empty string
There was a problem hiding this comment.
Also made this variable stored in prefs
There was a problem hiding this comment.
Instead of storing (current, previous) country codes where the current one can be DISCOVER_HIDE_FAKE_COUNTRY_CODE, I think it would be a lot more clear to store (country, hidden). Then we need to store one string and one boolean and don't need to move strings back and forth between the two variables.
|
Hello! |
|
Hello! |
ByteHamster
changed the title
app/src/main/java/de/danoeh/antennapod/fragment/DiscoveryFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/fragment/DiscoveryFragment.java
Outdated
Show resolved
Hide resolved
|
Can't |
Good point! Pushed new commit |
|
Thanks! Will be released in version 3.0 |
Hello!
This closes #6098.
Here's a demonstration video
https://imgur.com/a/4avAwIV