Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to migrate Echo to a new year #6803

Merged
merged 1 commit into from Dec 13, 2023

Conversation

ByteHamster
Copy link
Member

@ByteHamster ByteHamster commented Dec 11, 2023

Also, new screen background with expanding circles (waves) from the bottom, replacing one of the 2 stripes screens

@keunes
Copy link
Member

keunes commented Dec 13, 2023

Make it show every year automatically, without having to change code manually (getting out the update on time was too stressful, I don't want that next year)

This year you made everything from scratch in a very short period of time. I understand you don't want that again.

But I'm afraid that automatically publishing this every year might actually have the opposite effect: because it will get published automatically we will have/want to make changes, even if we realise this late. If we don't do them, it will be visible again with bugs or imperfections.

I would rather take the manual approach, where each year we make a decision to work on it in time or not. And then if we do, implement changes over, let's say, October, and release in November.

@keunes keunes added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Dec 13, 2023
@ByteHamster
Copy link
Member Author

The problem with "work on it on time" is that it still requires us to publish an update at a specific point in time. Even if we start it in August, we still have to make sure to get it released in time. So let's start right now and finish AntennaPod Echo 2024 in Jan/Feb. Then it's not as stressful as this year. What do you think we should change?

@keunes
Copy link
Member

keunes commented Dec 13, 2023

So let's start right now and finish AntennaPod Echo 2024 in Jan/Feb. Then it's not as stressful as this year.

Sure!

What do you think we should change?

Shall I create one or more tickets? Some might be easier to implement than others… (i.e. some might be in another PR, or for 2025)

@ByteHamster
Copy link
Member Author

ByteHamster commented Dec 13, 2023

I think one ticket with a checklist should be enough. These are probably rather small changes, I guess

Also, add a new screen background
@ByteHamster ByteHamster changed the title Echo 2024 preparation Make it easier to migrate Echo to a new year Dec 13, 2023
@ByteHamster ByteHamster removed the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Dec 13, 2023
@keunes
Copy link
Member

keunes commented Dec 13, 2023

I doubt that all will be small changes, but I'll create a ticket for it - let's see :-)

@ByteHamster ByteHamster merged commit db88dc1 into AntennaPod:develop Dec 13, 2023
7 checks passed
@ByteHamster ByteHamster deleted the echo-2024 branch December 13, 2023 21:40
@keunes
Copy link
Member

keunes commented Dec 13, 2023

Sorry, if we take this approach, can we then remove the automatic publishing of Echo? That was the whole point of starting work on Echo right now.

@ByteHamster
Copy link
Member Author

I changed the PR to be easier to update to a new year, no longer automatic

@keunes
Copy link
Member

keunes commented Dec 14, 2023

Sorry, I didn't see another commit so I assumed, shouldn't have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants