Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if volume boost effect is supported on the device #6808

Merged
merged 8 commits into from Dec 29, 2023
Merged

Check if volume boost effect is supported on the device #6808

merged 8 commits into from Dec 29, 2023

Conversation

matejdro
Copy link
Contributor

This is an attempt to fix #6802. I have no idea if it works (I cannot reproduce the issue on my device).

@ByteHamster ByteHamster changed the base branch from develop to master December 13, 2023 19:04
@ByteHamster
Copy link
Member

Could you please rebase your branch to master? I changed the target branch on GitHub to master but now there are unrelated changes from the develop branch. (this is a bugfix that should go directly to production, not just to the next full release)

@matejdro
Copy link
Contributor Author

You are right, I was a bit lazy here. Commited a better solution now.

ByteHamster
ByteHamster reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@ByteHamster ByteHamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks more clean to me now. I still have a small comment, however :)

model/src/main/java/de/danoeh/antennapod/model/feed/VolumeAdaptionSetting.java Outdated Show resolved Hide resolved
matejdro and others added 2 commits December 29, 2023 16:22
@matejdro @ByteHamster
Simplify isBoostSupported
f7d8926 
Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
@matejdro
Remove wrong Nullable marker
f10f8e9
@ByteHamster ByteHamster changed the title Sound fix attempt Check if volume boost effect is supported on the device Dec 29, 2023
@ByteHamster ByteHamster merged commit f476086 into AntennaPod:master Dec 29, 2023
7 checks passed
@ByteHamster
Copy link
Member

Thanks! Let's hope that this works. Will be released in AntennaPod 3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteHamster ByteHamster ByteHamster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media wont play in Version 3.2.0 (3020095)
2 participants
@matejdro @ByteHamster