Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share AntennaPod subscribe link instead of RSS url #6835

Merged
merged 1 commit into from Dec 31, 2023

Conversation

ByteHamster
Copy link
Member

Apparently users are confused by RSS links. Because of AntennaPod/antennapod.github.io#303, we can now add a title.

Apparently users are confused by RSS links.
@ByteHamster ByteHamster merged commit 28edb71 into AntennaPod:develop Dec 31, 2023
7 checks passed
@ByteHamster ByteHamster deleted the share-link branch December 31, 2023 10:08
quails4Eva pushed a commit to quails4Eva/AntennaPod that referenced this pull request Jan 20, 2024
@andrewc1
Copy link
Contributor

This may expose some user information in ways they don't expect. In particular, people with personal Patreon accounts will end up sharing their credentials with both the intended recipient and antennapod.org.

Short of keeping a list of forbidden RSS hosts (e.g., patreon.com), I can't think of an alternative that will work. (And some users may want to share their credentials... although probably not with antennapod.org).

@ueen
Copy link
Contributor

ueen commented Feb 26, 2024

Well I wouldn't consider this an issue, but if you really want to overengineer this you could also make the short URL a key and encrypt the URL and details in the db.
I would prefer to look at this from a user point of view: I just want to share the episode in an easy way (that may also promote AP) and let's someone else listen to it.
Overcast does it beautifully, it's not that difficult technically, let's just do it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants