Hide refresh from toolbar #6850
Conversation
update FeedUpdateRunningEvents
ueen
force-pushed
the
hide_refresh_from_toolbar
branch
from
6ba5651
to
29989b5
Compare
app/src/main/java/de/danoeh/antennapod/fragment/EpisodesListFragment.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/danoeh/antennapod/core/menuhandler/MenuItemUtils.java
Show resolved
Hide resolved
…agment.java Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
| @@ -457,7 +462,7 @@ protected void updateToolbar() { | |||
| @Subscribe(sticky = true, threadMode = ThreadMode.MAIN) | |||
| public void onEventMainThread(FeedUpdateRunningEvent event) { | |||
| if (toolbar.getMenu().findItem(R.id.refresh_item) != null) { | |||
| MenuItemUtils.updateRefreshMenuItem(toolbar.getMenu(), R.id.refresh_item, event.isFeedUpdateRunning); | |||
| swipeRefreshLayout.setRefreshing(event.isFeedUpdateRunning); | |||
There was a problem hiding this comment.
The if statement above is no longer needed
app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/fragment/SubscriptionFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/fragment/EpisodesListFragment.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
…agment.java Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
|
I didn't run it on my phone yet (don't have an Android IDE on my work computer), but this looks good to me. If you fix the unused imports, this should be ready to be merged. |
|
I tried this a while on my phone and the pull-to-refresh showing during the complete refresh is really annoying and looks like a bug. |
|
We need some indication for an ongoing refresh. The notification is not enough because users apparently don't want to grant the notification permission on Android 14. The app needs to fully work without notifications. |
|
Well, the app doesn't work without the notification service, if the app is quite during refresh... |
|
Wouldn't hiding it feel like the refresh was aborted early? Feel free to create an issue that we can discuss on the community call. I don't think this PR is the right place to discuss. |
lengthy discussion here
#6836