Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: remove special handling for Huawei #7152

Merged
merged 1 commit into from
May 1, 2024

Conversation

hades
Copy link
Contributor

@hades hades commented Apr 30, 2024

This was introduced in 5105cdd to prevent crashes on Huawei phones[1]. However, it seems this has already regressed in 376ffed, where the setActive call was moved outside of the try-catch block.

Additionally, the problem is now 9 years old, and hopefully fixed for the users already.

[1] https://stackoverflow.com/questions/31556679/android-huawei-mediassessioncompat

Description

Checklist

This was introduced in 5105cdd to prevent crashes on Huawei phones[1].
However, it seems this has already regressed in 376ffed, where the setActive
call was moved outside of the try-catch block.

Additionally, the problem is now 9 years old, and hopefully fixed for the users
already.

[1] https://stackoverflow.com/questions/31556679/android-huawei-mediassessioncompat
@ByteHamster ByteHamster merged commit 292a21f into AntennaPod:develop May 1, 2024
6 checks passed
@ByteHamster
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants