Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant hints on search screen #7219

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

flofriday
Copy link
Contributor

Description

On the search screen there was always the message "no results found" even before anything was ever searched and the message was repeated beneath it if really nothing was found by the app.

Screenshot (Left two Before, Right ones After):
aösldfkjaasddf

Question for the Reviewer

In the EmptyViewHandler.java file many (but not all) private field names are prepended with the type they are of. Like the TextView for the title is called tvTitle. I haven't seen such Hungarian Notation in other parts of the app, so I assume they are a relict of the past. Should I also remove them since this PR already touches the file?

Checklist

On the search screen there was always the message "no results found"
even before anything was ever searched and the message was repeated
beneath it if really nothing was found by the app.
@ByteHamster ByteHamster merged commit e2ff09b into AntennaPod:develop Jun 7, 2024
6 checks passed
@ByteHamster
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants