Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty home sections #7221

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

flofriday
Copy link
Contributor

Description

Previously sections on the homescreen sometimes didn't contain any content if for example there weren't no downloads. Now only sections with useful information will be shown, which should be much cleaner for new users, which haven't listened to anything yet.

As a techical detail, the sections don't get removed from the homescreen but just hide them self. This way they can still be listening to updates and just need to unhide themself if new relevant podcasts/episodes appear.

Screenshot (left before, right this PR):
image

Checklist

Previously sections on the homescreen sometimes didn't contain any
content if for example there weren't no downloads.
Now only sections with useful information will be shown, which should
be much cleaner for new users, which haven't listened to anything yet.
@loucasal
Copy link
Contributor

loucasal commented Jun 3, 2024

This is one of the suggestions I made in #6824, so great to see it picked up. See that ticket for some closely related ideas (all still to be tackled).

@flofriday
Copy link
Contributor Author

You are right, I musst have missed it but your issue contains even more suggestions we could work on ;)

@keunes keunes added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Jun 3, 2024
@keunes
Copy link
Member

keunes commented Jun 3, 2024

Super that you worked on this (and all the other stuff)! I just added the 'Needs: Decision' label because I'm not sure of we want to hide them all if empty, because it also limits discoverability of the sections. Also this could lead to unexpected behaviour where you enable/activate a section but it doesn't show, because no content is available

Another option that doesn't have these downsides is an 'empty state' screen. Like a simple graphic to go with a short note.

If not for all sections, then maybe for some (e.g. more important for Queue than for Inbox).

@flofriday
Copy link
Contributor Author

No problem at all, just displaying an empty message instead of hiding the section should be an easy fix and could be the better solution since the sections can be disabled (which I kinda forgot).

@keunes
Copy link
Member

keunes commented Jun 14, 2024

Discussed with @ByteHamster:

  • we will want to keep Queue to encourage users to add content. So those we'd already keep.
  • For the Inbox it's a bit unexpected for the inbox to disappear
  • Subscriptions will always have something (there is a full empty state screen if you don't have subscriptions yet)
  • if you're a user gradually starting to use AP, then some sections might start appearing & disappearing

So we prefer to have 'empty state' for all.

We considered having something like the 'loading' placeholder images (with text on top), but that would get too busy:

So we decided to go for only texts right now, in future to be complemented with a nice empty-state image (to be designed by a designer). Text would be vertically & horizontally centred (but with smaller margins). We'll create dedicated strings (we'll think about the exact text in the coming time). The existing texts come out a bit too long (a GIMP mock-up):

@keunes keunes removed the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants