-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty home sections #7221
base: develop
Are you sure you want to change the base?
Fix empty home sections #7221
Conversation
Previously sections on the homescreen sometimes didn't contain any content if for example there weren't no downloads. Now only sections with useful information will be shown, which should be much cleaner for new users, which haven't listened to anything yet.
This is one of the suggestions I made in #6824, so great to see it picked up. See that ticket for some closely related ideas (all still to be tackled). |
You are right, I musst have missed it but your issue contains even more suggestions we could work on ;) |
Super that you worked on this (and all the other stuff)! I just added the 'Needs: Decision' label because I'm not sure of we want to hide them all if empty, because it also limits discoverability of the sections. Also this could lead to unexpected behaviour where you enable/activate a section but it doesn't show, because no content is available Another option that doesn't have these downsides is an 'empty state' screen. Like a simple graphic to go with a short note. If not for all sections, then maybe for some (e.g. more important for Queue than for Inbox). |
No problem at all, just displaying an empty message instead of hiding the section should be an easy fix and could be the better solution since the sections can be disabled (which I kinda forgot). |
Discussed with @ByteHamster:
So we prefer to have 'empty state' for all. We considered having something like the 'loading' placeholder images (with text on top), but that would get too busy: So we decided to go for only texts right now, in future to be complemented with a nice empty-state image (to be designed by a designer). Text would be vertically & horizontally centred (but with smaller margins). We'll create dedicated strings (we'll think about the exact text in the coming time). The existing texts come out a bit too long (a GIMP mock-up): |
Description
Previously sections on the homescreen sometimes didn't contain any content if for example there weren't no downloads. Now only sections with useful information will be shown, which should be much cleaner for new users, which haven't listened to anything yet.
As a techical detail, the sections don't get removed from the homescreen but just hide them self. This way they can still be listening to updates and just need to unhide themself if new relevant podcasts/episodes appear.
Screenshot (left before, right this PR):
![image](https://private-user-images.githubusercontent.com/21206831/336131671-935ac32b-2553-45e0-be10-881db0fc24bf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NTgzNTcsIm5iZiI6MTcyMDU1ODA1NywicGF0aCI6Ii8yMTIwNjgzMS8zMzYxMzE2NzEtOTM1YWMzMmItMjU1My00NWUwLWJlMTAtODgxZGIwZmMyNGJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDIwNDczN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkYTMxNzA1MDRkYjQ0N2JmMTYzMzFmN2ExZGViMGE5MGFlMDIzNGVmYjA2NmJjZGQ2OTJkMWMwOWFlYThjZTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fyUd-XLHU5GFSRJ6o_kUg3t4sdmq0VJtTOc-YbaSg0I)
Checklist
./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug