Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform action on episodes #974

Merged
merged 3 commits into from
Jun 28, 2015

Conversation

mfietz
Copy link
Contributor

@mfietz mfietz commented Jun 27, 2015

Something to play with. Not very well tested yet.

Something to look at:

muh

@TomHennen
Copy link
Contributor

Will this wind up taking the place of #945?

  • Doesn't actually add the episodes in the order displayed. I think this is because 'episodes' is what gets sorted. But checkedIds isn't. If I clear all checked, sort, check all, then add it works correctly.
  • If people like this it could be added to All and New Episodes (though we might want to hold off on that)
  • It's bit of a complicated user interface, but I don't see how to make it simpler and handle everything requested.

@mfietz
Copy link
Contributor Author

mfietz commented Jun 27, 2015

Order should now be correct. Also several optimizations.

I guess this looks complicated because it is new and there is no UI like it yet. Shouldn't take long for people to figure out how this thing works.
We could add tooltips with the supertooltips library, but that would look rather childish to me. Either we let the users explore the UI or we have some explanatory image on first usage that explains some of the UI elements (e.g. that those two arrows are for sorting...)

@TomHennen TomHennen self-assigned this Jun 27, 2015
@TomHennen TomHennen added this to the 1.3 milestone Jun 27, 2015
@TomHennen
Copy link
Contributor

I don't think tooltips are needed.

I did run in to something strange with the coloring of the checkboxes. I unchecked one, they all turned grey, then as I scrolled, this happened:

screenshot 2015-06-28 14 44 48

Collections.sort(episodes, new Comparator<FeedItem>() {
@Override
public int compare(FeedItem lhs, FeedItem rhs) {
int code = lhs.getMedia().getDuration() - rhs.getMedia().getDuration();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break for feeds that have items without media.

@TomHennen
Copy link
Contributor

Otherwise, looks good.

@mfietz
Copy link
Contributor Author

mfietz commented Jun 28, 2015

Everything fixed, except for the "I forgot how to checkbox" glitch

TomHennen added a commit that referenced this pull request Jun 28, 2015
@TomHennen TomHennen merged commit cff363e into AntennaPod:develop Jun 28, 2015
@mfietz mfietz deleted the feature/episodes-actions branch September 17, 2015 17:41
@keunes keunes mentioned this pull request Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants