Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

Update install.py #623

Merged
merged 3 commits into from Jun 21, 2016
Merged

Update install.py #623

merged 3 commits into from Jun 21, 2016

Conversation

TheWyn
Copy link
Member

@TheWyn TheWyn commented Jun 21, 2016

Added Antergos Repo and Staging (Commented) to the proper spot in /etc/pacman.conf.

Add Antergos Repo and Staging (Commented) to the proper spot.
@TheWyn
Copy link
Member Author

TheWyn commented Jun 21, 2016

@lots0logs It would be below testing, don't want that.

How this merge looks: 9eeefb8b6f1206736e7f0ddd464e35a4

(You made a comment note then deleted it...?)

@@ -774,10 +774,10 @@ def update_pacman_conf():
else:
Copy link
Member

@lots0logs lots0logs Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this instead:

elif pacline == '[testing]\n':
    pacman_file.write('\n\n#[antergos-staging]\n')
    pacman_file.write('#SigLevel = PackageRequired\n')
    pacman_file.write('#Include = /etc/pacman.d/antergos-mirrorlist\n\n')
    pacman_file.write('[antergos]\n')
    pacman_file.write('SigLevel = PackageRequired\n')
    pacman_file.write('Include = /etc/pacman.d/antergos-mirrorlist\n\n')
    pacman_file.write(pacline)
else:
    pacman_file.write(pacline)

Its kind of ugly but since I am trying to write this on github as feedback for you instead of doing it myself in the code its the best I can do 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lots0logs It's still after testing, it shouldn't be since the main priority is Antergos. If testing was used staging would be used at the same time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it shouldnt be. Maybe there is a typo or something. I cant check it now. But the code I provided specifically writes the testing line after writing the antergos lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hows that instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better but we dont want to have lines longer than 99 characters as that is against Python Coding Standards. That's why I recommended doing it the way that I did above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lots0logs

Done.

99 characters as that is against Python Coding Standards

That'll be very hard for me to follow, bad habits catching up with me 👀.

Added to loop
Character per line limit
@lots0logs lots0logs merged commit 74daaeb into Antergos:master Jun 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants