Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

opera-developer :: fix checksums + correct symlink #55

Closed
wants to merge 1 commit into from
Closed

opera-developer :: fix checksums + correct symlink #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions opera-developer/PKGBUILD
View file
Open in desktop
Expand Up @@ -17,8 +17,8 @@ install=opera.install
options=(!strip)
source_i686=("http://get.geo.opera.com/pub/${pkgname}/${pkgver}/linux/${pkgname}_${pkgver}_i386.deb")
source_x86_64=("http://get.geo.opera.com/pub/${pkgname}/${pkgver}/linux/${pkgname}_${pkgver}_amd64.deb")
sha256sums_i686=('6a8cebc47e2cfb121617f0c51f1974d74ef742037757fcca3a011c0f7341705a')
sha256sums_x86_64=('9cfad413d4f23f2881bf53bea94227e6dd6259c1461b80bdc216b8816ea6be46')
sha256sums_i686=('be60c87212307a06d7628761b9bb16e15c2bc7d711957467b4c55e2f7f868b32')
sha256sums_x86_64=('36e153c3778ab543ea0b0921534f42dd689aaadd1fe0aac43d5e5fcb832a8a58')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are updated automatically on our server when the packages are built.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a way it is annoying you don't share a 'working' version of the pkgbuild. If someone uses your repo to build opera-develper that someone must first run updpkgsums before being able to run makepkg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that to be expected if you are building packages for your own repo anyway? It is a part of the packaging process. Otherwise why not just add our repo and use it directly? This github repo is not the AUR, that's not its intended purpose. However, with that said, it wouldn't be difficult to have the server update the PKGBUILD's with the new checksums. I'll add it to my todo list. Cheers!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only trying to help other people ;). I have opera-developer in my own repo.


#prepare() {
#}
Expand All @@ -39,6 +39,6 @@ package() {

unlink ${pkgdir}/usr/bin/${pkgname}
cd ${pkgdir}/usr/bin
ln -sr ../usr/lib/opera-developer/opera-developer
ln -sf /usr/lib/${pkgname}/${pkgname}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to look into this. At first glance I don't see a problem. I'll check on it ASAP. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone using antergos reported to me that opera-developer was no longer working

your symlink does not point to the actual binary

you could change it to
ln -sr ../lib/opera-developer/opera-developer

or make it more obvious with the
ln -sf /usr/lib/${pkgname}/${pkgname}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will check it out. The last couple releases I havent been able to build it because the source url was returning a 404 Forbidden error. Though it was only doing it when accessed from our build server. As soon as I have some time I will check on it.