Edits to the Map Sorting proposal #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the good feedback! For each of your points, I've gone back and either updated the proposal or provided additional rationale. |
|
Thanks for being patient! Do you mind if I squash? |
|
sgtm, thanks for hashing everything out. It's a pretty good-looking proposal now 😄 |
|
@AnthonyLatsis can you go back and update the pitch thread? It may also be nice to drop a note in apple/swift-evolution#999 |
AnthonyLatsis
pushed a commit
that referenced
this pull request
Sep 9, 2022
…om the third review (apple#1406) * [SE-0304] Replace `TaskGroup.async` with `TaskGroup.addTask`. The use of the adjective `async` for creating new child tasks was too confusing and didn't fit well with the naming guidelines. Instead, use `addTask`, which makes it clear that we are adding a new task into a task group (the result of which is available via `next()`). * [SE-0304] Rename `sleep(_:)` to `sleep(nanoseconds:)`. * [SE-0304] Split out changes due to review #3 * [SE-0304] Rename TaskPriority.default to TaskPriority.medium * [SE-0304] Add (Throwing)?TaskGroup.waitForAll * [SE-0304] Rename `Task.yield()` to `Task.suspend()` * [SE-0304] Make `Task.sleep(nanoseconds:)` throwing on cancellation * Re-schedule review
AnthonyLatsis
pushed a commit
that referenced
this pull request
Sep 9, 2022
* Initial draft * Revise proposal and narrow it to @predatesConcurrency * Add examples and describe @predatesConcurrency protocol behavior * Rename `@predatesConcurrency` to `@preconcurrency` * Clarify that using concurrency features enables Sendable checking. * Simplify from 3 "concurrency checking modes" to 2. We only need "minimal" and "strict"; the other differences are accounted for by the language mode (warnings prior to Swift 6, errors thereafter) and the behavior of the `@preconcurrency` attribute. * Remove an extraneous space * Add links to implementation, toolchains, pitch #3 thread * Update proposals/NNNN-support-incremental-migration-to-concurrency-checking.md Co-authored-by: Jon Shier <jon@jonshier.com> * Assign number, kick off review Co-authored-by: Ben Cohen <airspeedswift@users.noreply.github.com> Co-authored-by: Jon Shier <jon@jonshier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some edits to the proposal! Let me know what you think.