Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable ua #45

Merged
merged 7 commits into from
Apr 21, 2022
Merged

Stable ua #45

merged 7 commits into from
Apr 21, 2022

Conversation

AnthonyZJiang
Copy link
Owner

No description provided.

@@ -104,6 +120,7 @@ const WAIT_FOR_ONLINE_TIMEOUT = 60000;
const googleTrend = new GoogleTrend();
const userDailyStatus = new DailyRewardStatus();
const searchQuest = new SearchQuest(googleTrend);
let developer = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

developer = json;
console.log('Developer mode enabled.');
console.log(developer);
}).catch((ex) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

const devJson = chrome.runtime.getURL('developer.json');
const fetchProm = await fetch(devJson, {method: 'GET'}).then((response) => {
return response.json();
}).then((json) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

@@ -14,6 +15,22 @@ function loadSavedSettings() {
});
}

async function getDeveloperSettings() {
const devJson = chrome.runtime.getURL('developer.json');
const fetchProm = await fetch(devJson, {method: 'GET'}).then((response) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

@@ -14,6 +15,22 @@ function loadSavedSettings() {
});
}

async function getDeveloperSettings() {
const devJson = chrome.runtime.getURL('developer.json');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

return flag + 2 * (!this._status_.mbSearchStatus.isValidAndCompleted && (mbSearchProgBefore == this._status_.mbSearchStatus.progress));
}

async _getAlternativeUA(flag) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class properties must be methods. Expected '(' but instead saw '_getAlternativeUA'.
Duplicate class method 'async'.

src/quest/searchQuest.js Show resolved Hide resolved
src/quest/searchQuest.js Show resolved Hide resolved
src/quest/searchQuest.js Show resolved Hide resolved
src/quest/searchQuest.js Show resolved Hide resolved
@AnthonyZJiang AnthonyZJiang merged commit 50899a1 into master Apr 21, 2022
@AnthonyZJiang AnthonyZJiang deleted the stable-ua branch April 21, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant