Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang版插件 #5

Closed
wants to merge 6 commits into from
Closed

golang版插件 #5

wants to merge 6 commits into from

Conversation

demonsec666
Copy link

image

demonsec666 added 6 commits January 29, 2020 17:13
golang
更新
更新
更新
更新
更新
@Anthonyeef
Copy link
Owner

Hi,
可以简单整理一下 commit 提交记录(避免出现多个 commit,但 commit message 都是 更新 的情况),
然后在项目的根目录下新增一个 other-languages 的目录,往那里头放代码吧 🙏

@imWildCat
Copy link

@Anthonyeef 能否 squash commit?

@Anthonyeef
Copy link
Owner

@imWildCat 可以

@demonsec666
Copy link
Author

demonsec666 commented Feb 1, 2020

需要怎么整理,不太懂 @Anthonyeef

@demonsec666 demonsec666 closed this Feb 1, 2020
@Anthonyeef
Copy link
Owner

@demonsec666
随手 commit 是好习惯,我自己在开发的过程中也会进行粒度较细的 commit 来暂存目前的工作进度;
但如果是在 Git 这样的多人协作场景,往主 branch 提交代码的时候,就不应该留下这么多没有意义的 commit message 了。好的做法是在提交之后、合入之前,先进行一次 commit 的整理:
比如你的这个提交:
image

从 commit 记录来看,感觉这些 commit 都可以合并成一个 commit,commit message 也可以写得有意义一些。这样我在 review 你的提交的时候,可以在一个 commit 里就看到一个完整的、有意义、有自己上下文的 commit。

当然不是说每个 PR 都必须是一个 commit… commit 的拆分也有一些讲究。就你的这个提交的话,我感觉完全可以在一个 commit 里完成。

(具体做法的话,最简单粗暴的就是先 reset,再 add . 后重新 push to remote 了 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants