Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat groups #19

Closed
danimesq opened this issue Apr 11, 2017 · 14 comments
Closed

Chat groups #19

danimesq opened this issue Apr 11, 2017 · 14 comments

Comments

@danimesq
Copy link
Contributor

No description provided.

@AnthyG
Copy link
Owner

AnthyG commented Apr 11, 2017

This should follow #6 !

@danimesq
Copy link
Contributor Author

You can create milestones in order to organize issues' priorities.

@AnthyG AnthyG modified the milestones: Private Chat, Grou Apr 11, 2017
@AnthyG AnthyG added this to Group Chat in Private and Group Chats Apr 11, 2017
@AnthyG
Copy link
Owner

AnthyG commented Nov 30, 2017

I will probably have to improve the code for the private chat..
though both would basically use the same functions (except that group chat won’t use ecies to encrypt, because that would be bad for big groups, so just AES)

I should probably also extract some code-parts from lobby- and private-chat, to shorten the code, because for private-chat I just copied all of the lobby-chat parts and just edited them to fit private chats, which is somewhat a bad habit of mine.

So I will re-write the addMessage-function to work for all things, which will require some time.

Also see the following link for some differences between private chat and lobby chat
https://www.diffchecker.com/5mjB8rtG

@danimesq
Copy link
Contributor Author

@AnthyG the chat groups will have options to be public or password-protected?

@AnthyG
Copy link
Owner

AnthyG commented Dec 1, 2017

@Plasmmer there could be something like a index for public groups, but as anybody could theoretically just create a new group by changing the URL, so I'm not sure if the first person in a group should even be logged (so it that would be the group-"admin"), because it would just take up extra storage.
The "password-protection" of a group is the group's ID, which can be quite long, if you want to enter it into the address bar 😆

So no, and somewhat-yes.

@AnthyG
Copy link
Owner

AnthyG commented Dec 3, 2017

The branch for this can be found at https://github.com/AnthyG/ThunderWave/tree/Group-Chat

@AnthyG AnthyG self-assigned this Dec 3, 2017
@AnthyG
Copy link
Owner

AnthyG commented Dec 3, 2017

Added basic functionality with commit e6ba8f7!
You can now try a link like this: http://127.0.0.1:43110/thunderwave.bit/?GC:Abcdefghijklmnopqrstuvwxyz

@AnthyG
Copy link
Owner

AnthyG commented Dec 3, 2017

Next up is to “merge” the mostly similar functions from lobby, private, and group chat together, to reduce the code-size, and to make it more “modular”

@AnthyG
Copy link
Owner

AnthyG commented Dec 6, 2017

I will close this issue, and create some for already found bugs in group chat, as this was just for the basic implementation for groups.

@AnthyG AnthyG closed this as completed Dec 6, 2017
@AnthyG
Copy link
Owner

AnthyG commented Jul 23, 2018

Merging the functions as noted in #19 (comment) is being worked on in ThunderWave Beta. For more information, see #106.

@danimesq
Copy link
Contributor Author

@AnthyG you can use Bitcoin addresses in the groups, so who have the privatekey is owner of a group.
Or a system where owner can add other admins/roles.

@AnthyG
Copy link
Owner

AnthyG commented Aug 15, 2018

@DaniellMesquita I think using the private-/ public key pair for groups should be a new issue.

@AnthyG
Copy link
Owner

AnthyG commented Aug 15, 2018

Actually, I'm not sure how I would implement that 😆
Because I can't just use the public key of a user to create a group,.. everybody knows that key.

@danimesq
Copy link
Contributor Author

Reference: #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants