-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat groups #19
Comments
This should follow #6 ! |
You can create milestones in order to organize issues' priorities. |
I will probably have to improve the code for the private chat.. I should probably also extract some code-parts from lobby- and private-chat, to shorten the code, because for private-chat I just copied all of the lobby-chat parts and just edited them to fit private chats, which is somewhat a bad habit of mine. So I will re-write the Also see the following link for some differences between private chat and lobby chat |
@AnthyG the chat groups will have options to be public or password-protected? |
@Plasmmer there could be something like a index for public groups, but as anybody could theoretically just create a new group by changing the URL, so I'm not sure if the first person in a group should even be logged (so it that would be the group-"admin"), because it would just take up extra storage. So no, and somewhat-yes. |
The branch for this can be found at https://github.com/AnthyG/ThunderWave/tree/Group-Chat |
Added basic functionality with commit e6ba8f7! |
Next up is to “merge” the mostly similar functions from lobby, private, and group chat together, to reduce the code-size, and to make it more “modular” |
I will close this issue, and create some for already found bugs in group chat, as this was just for the basic implementation for groups. |
Merging the functions as noted in #19 (comment) is being worked on in ThunderWave Beta. For more information, see #106. |
@AnthyG you can use Bitcoin addresses in the groups, so who have the privatekey is owner of a group. |
@DaniellMesquita I think using the private-/ public key pair for groups should be a new issue. |
Actually, I'm not sure how I would implement that 😆 |
Reference: #116. |
No description provided.
The text was updated successfully, but these errors were encountered: