Fixed bugs with Line_PortalSetTarget and added more portal geometry warnings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arnings - A bug exists where portals that have been deactivated with Line_PortalSetTarget cannot be reactivated, even if given a valid target. - Another bug exists where portals that were created in an inactive state (using a target line tag of 0) could never be activated. (Even with the above bugfix.) - Linked portals that have been demoted to teleport portals because they do not have a return portal now emit a warning. - Portals that are supposed to be traversable, but do not have back-sector now demote to visual portals and emit a warning, because nothing could ever possibly traverse them anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see now that there's another pull request (ZDoom#372) to fix the first bug in a slightly different way. I'm not sure which change is more appropriate, since I'm barely familiar with the portal code, but this is my take on it. It looks like the mFlags member is the main method of tracking whether portals are active, so it looks like it should always updated in the ChangePortalLine function.
I updated Gez's original portal test map from the original portal thread. I got everything working except for the switchable portals, which is what caused me to stumble on these bugs. Here's the updated version for testing: zdoomx_test0_upd.zip