Only send desktop notification if the list of available updates differs from the last check #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs from the last check Currently, the desktop notification included in the `check()` function is sent whenever there are update available without any sort of filter. That means that, with the systemd timer triggering the `check()` function each hour, you will get a notification for the same exact available updates each hour over and over until you actually apply them (in the eventuality that there's no other available updates in the mean time). This commit makes the `check()` function verify that the current list of available updates differs from the one obtained by the last check before re-sending a notification. That way, a new notification is sent only if there are new available updates compare to the last check so you don't get multiple notifications for the exact same update over time.
This directory and the files contained in it are only relevant for the desktop notifications
…re are pending updates That makes the current_check and last_check files reflectst the reality by being emptied if there are no update available. The diff is only ran if the variable isn't empty so there won't be any false positive.
…update_available var value to it When there are no update available, redirecting the value of the update_available var (which is then empty) to the file produces an empty (but existing) line. This commit aims to remove it so the file is actually empty (instead of containing an empty/blank line).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the desktop notification included in the
check()function is sent whenever there are update available without any sort of filter.That means that, with the systemd timer triggering the
check()function each hour, you will get a notification for the same exact available updates each hour over and over until you actually apply them (in the eventuality that there's no other available updates in the mean time).This commit makes the
check()function verify that the current list of available updates differs from the one obtained by the last check before re-sending a notification.That way, a new notification is sent only if there are new available updates compared to the last check so you don't get multiple notifications for the exact same update over time.