Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive and intempestive 'pending kernel update' messages on EndeavourOS with systemd-boot #75

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Dec 4, 2023

EndeavourOS does not use /boot to store vmlinuz* files when using systemd-boot (I couldn't find much details about a specific reason for that, attempts at analyzing here).

This PR aims to make the script fallback to /usr/lib/modules/*/vmlinuz* if vmlinuz* files are not found under /boot. This prevents false positive and intempestive 'pending kernel update' messages on EndeavourOS + systemd-boot.

Fixes #74

…on EndeavourOS with systemd-boot

EndeavourOS does not use '/boot' to store 'vmlinuz*' files when using systemd-boot (I couldn't find much details about a specific reason for that, attemps at analyses [here](#74 (comment)).

This commit aims to make the script fallback to '/usr/lib/modules/*/vmlinuz*' if 'vmlinuz*' files are not found under '/boot'.
This prevents false positive and intempestive 'pending kernel update' messages on EndeavourOS + systemd-boot
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 42d79c0 into main Dec 4, 2023
1 check passed
@Antiz96 Antiz96 deleted the endeavouros_fix branch December 4, 2023 23:24
Antiz96 added a commit that referenced this pull request Mar 21, 2024
…for EndeavourOS)

The fix implemented for EndeavourOS in #75 can create false positives in case some old-ish/outdated kernel related files are [laying in /boot](#74 (comment)) *for some reasons... (?)*
This commit aims to make the pending kernel update detection more robust to avoid such potential false positives by making Arch-Update looking for kernel related files in **both** /boot and in /usr/lib/modules/* (instead of falling-back to the latter only if kernel files are not found in the former).

Fixes #74
Antiz96 added a commit that referenced this pull request Mar 21, 2024
…for EndeavourOS) (#129)

The fix implemented for EndeavourOS in #75 can create false positives in case some old-ish/outdated kernel related files are [laying in /boot](#74 (comment)) *for some reasons... (?)*
This commit aims to make the pending kernel update detection more robust to avoid such potential false positives by making Arch-Update looking for kernel related files in **both** /boot and in /usr/lib/modules/* (instead of falling-back to the latter only if kernel files are not found in the former).

Fixes #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pending kernel update message persisting after reboot on EndeavourOS
1 participant