A bunch of changes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change/add add-on categories as per http://forum.getnightingale.com/thread-606-post-5428.html#pid5428 In table.php: I wasn’t sure what the point of putting feathers in the “if ($data['includetemplates'])” block was. I assumed this was for some requirement of DokuWiki that does not apply to us. Let me know if/why this needs to stay.
zjays
changed the title
Remove popularity column for now - comment lines out in case we want to bring it back
Requires adding "icon_img:" & link to icon image in add-on page syntax. If no icon image, use default Nightingale add-on icon. Preview: http://i.imgur.com/T5J3zF5.jpg
Make more room for screenshot, set max-width such that it is not wider than allotted room to left of action items Preview: http://i.imgur.com/v1dRrZi.jpg
Note that this assumes the new add-on repository table, when completed, will be moved to "http://wiki.getnightingale.com/doku.php?id=add-ons" (ie. replacing the current add-on page namespace). Let me know if this is not the case!
- Move download button to top right of entry page - Rename "Download" to "Add to Nightingale" (mimic Firefox add-on page) - Change icon to a plus symbol (mimic Firefox add-on page) - Preview: http://i.imgur.com/rFv7bFx.jpg
- Float everything right except for back button, icon, description, screeenshot - Autosize back button width - Preview: http://i.imgur.com/gWWAAfJ.jpg
Fixes Tools & Utilities add-ons not showing in table, and Tools & Utilities category not showing in entry
Category filter needed to be wider so that it wasn't so tall, now that we have 7 categories. May need to re-adjust again if for example, tag cloud becomes much taller than category filter
Needs to be listed in descending order, and get rid of 1.12.2
zjays
changed the title
Warning was "Plugin name contains underscore, will not generate popularity points." Not relevant to Nightingale add-ons (for now).
Change 32 to 33 in to fix table sorting issues for plugin 32 (Tools & Utilities)...not the most proper fix, but I didn't know how to properly re-write it otherwise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments for each individual commit
More information: http://forum.getnightingale.com/thread-605-post-5459.html#pid5459