Debugger fix #32
Debugger fix #32
Conversation
…s with get instead of get_f
|
@KGrykiel can you please assign reviewers and yourself as the assignee? I have a feeling @AntonLydike doesn't automatically gets a notification for PRs, but it's good practice in general to make it more likely that the people you want look at your GitHub PRs :) |
| @@ -147,7 +147,10 @@ def dump_reg_a(self): | |||
| ) | |||
|
|
|||
| def _reg_repr(self, reg: str, name_len=4, fmt="08X"): | |||
| txt = "{:{}}=0x{:{}}".format(reg, name_len, self.get(reg, False), fmt) | |||
| if(reg in self.float_regs): | |||
| txt = "{:{}}={: .3e}".format(reg, name_len, self.get_f(reg, False)) | |||
removed the debugger activation
|
Can you please run |
riscemu/registers.py
Outdated
| if ( | ||
| reg in self.valid_regs | ||
| and self.get(reg, False) == 0 | ||
| and reg not in Registers.named_registers() | ||
| or reg in self.float_regs | ||
| and self.get_f(reg, False) | ||
| ): |
There was a problem hiding this comment.
What in tarnation? Can we make this a bit more readable?
There was a problem hiding this comment.
What in tarnation? Can we make this a bit more readable?
I had to create a seperate formatting condition for changing empty float registers into the gray colour so that it also uses get_f instead of get. It started out as two seperate if statements, one for regular registers (reg in self.valid_regs and self.get(reg, False) == 0 and reg not in Registers.named_registers()) and one for float registers (reg in self.float_regs and self.get_f(reg, False)), but I decided to combine them with an or since they led to the same result. Could split them up again perhaps?
There was a problem hiding this comment.
Maybe you can also do something like this?
should_color_float = reg in self.float_regs and self.get_f(reg, False) != 0
should_color_int = reg in self.valid_regs and (
self.get(reg, False) != 0
or reg in Registers.named_registers()
)
if should_color_float or should_color_int:
# print colored
else:
# print greyThere was a problem hiding this comment.
ye, sounds good as well, I'm on it
fixed an issue where debugger had an error when trying to dump registers. It tried to use get() method instead of get_f() method. Also changed format of floating point registers to show up as floats instead of Hex.