Fix typos #45
Merged
Fix typos #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
That's pretty cool, I wasn't aware of such a spell-checker. @AntonLydike is on holidays for a bit, would be great to merge when he gets back.
|
Hi, thanks for the fixes! I'm a bit hesitant to add codespell as a dev-dependency to the project though, as I try to be careful to contain the dependency tree. Could you remove the addition of codespell from this PR? |
AntonLydike
reviewed
Sep 25, 2023
Co-authored-by: Anton Lydike <me@AntonLydike.de>
kianmeng
force-pushed
the
fix-typos-add-codespell-pre-commit-hook
branch
from
37b1596
to
46292aa
Compare
|
🥳 🥳 🥳 🥳 🥳 |
|
Thanks again for the patch! |
Joshy-R
pushed a commit
to Joshy-R/riscemu
that referenced
this pull request
Oct 13, 2023
* Fix typos Found via `codespell -L fle,sie` * Update riscemu/decoder/__main__.py Co-authored-by: Anton Lydike <me@AntonLydike.de> * Remove codespell --------- Co-authored-by: Anton Lydike <me@AntonLydike.de>
AntonLydike
added a commit
that referenced
this pull request
May 14, 2024
* fix jarl argument assertion bug * fix mulh bug * implement mulhsu and mulhu * Fix typos and add codespell pre-commit hook (#45) * Fix typos Found via `codespell -L fle,sie` * Update riscemu/decoder/__main__.py Co-authored-by: Anton Lydike <me@AntonLydike.de> * Remove codespell --------- Co-authored-by: Anton Lydike <me@AntonLydike.de> * Add p2align assembler directive (#46) * add p2align assembler directive * black * add p2align to changelog * Big cleanup work (#47) This moves a lot of internal data structures from `types` into `core`, because some imports got confused apparently. It also adds csr registers, performance improvements, etc. * release 2.2.0 * fix python publish * official bump commit * a bunch of minor fixes * version bump 2.2.2 * Add support for flen=64 (#49) Currently still missing a lot of the D extension (all except `fmadd, fmsub, fnmsub, fnmadd, fadd, fsub, fmul, fdiv, fsqrt, fsgnj, fsgnjn, fsgnjx, fmin, fmax, feq, flt, fle, fld, fsd`), missing conversion and move instructions. This may break some of the float32 stuff, so we should be very careful with this. * fix a few minor errors * fix a bug with libc not being found by packaged versions of riscemu * update pyelftools, add importlib-resources as dependency * fix issue with importlib.resources not working on python 3.8 * add missing float registers * update changelog * Snitch frep extension support (#50) This patch adds the frep extension to the snitch emulator. Register staggering is not supported currently, but could be added at a later date. This patch also adds f64 support to the xssr extension. * release 2.2.4 * fix SimpleInstruction.get_imm and add test * release 2.2.5 * add filecheck test * Fix error from merge * fix filecheck to print unsigned values when needed --------- Co-authored-by: Kian-Meng Ang <kianmeng.ang@gmail.com> Co-authored-by: Anton Lydike <me@AntonLydike.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.