-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo with latest library versions #12
Conversation
…ith latest gradle build and migrate to androidx
Hi @nowshad-hasan! I missed the GitHub notification for this pull request among many other notifications. 😓 Let me have a look to the changes. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nowshad-hasan if you cannot merge the pull request tell me and I'll do it. |
Hi @AntonioRedondo, you can merge this pull request because I don't think I've got the permission to do it. And really thanks for your PR review. |
Hi @AntonioRedondo , I accidentally made the commits with my job email not the regular email my GitHub is connected to. So, my profile is not shown up on the contributors list. Is there any workaround to solve this? Though this PR is showing on my profile. So, if it's a huge mess up for you, that will be completely unnecessary. |
@nowshad-hasan ouch, that really sucks! I removed last changes. Open another pull request with the right email account and I'll merged it. |
Hi @AntonioRedondo , I've made another PR with my regular email. |
Hi @AntonioRedondo , really thanks for your effort to make the |
I don't think you can actually do that if you have What I did to revert your changes was: git reset --hard HEAD~1 // It will erase any commit after HEAD~1, in this case, your PR changes
git push -f // We need to push to master the above changes. It's a destructive operation as we're forcing (-f) our branch history over the existing one in the repo. Then merge your pull request. But the new commit in |
Oh! That's great. Thanks for the idea 😃 . |
I've made some changes regarding these issues: