Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default value to $actionSegment #13

Merged
merged 1 commit into from Jan 6, 2020
Merged

Added default value to $actionSegment #13

merged 1 commit into from Jan 6, 2020

Conversation

bencroker
Copy link
Contributor

@bencroker bencroker commented Jan 6, 2020 •
edited

AJAX requests to the URI /admin result in the following error:

PHP Notice 'yii\base\ErrorException' with message 'Undefined offset: -1' 
in /Users/ben/Sites/laloupe.com/vendor/anubarak/craft-relabel/src/services/RelabelService.php:369

This pull request fixes this by adding a default value of null to $actionSegment if the array value is undefined.

@bencroker
Update RelabelService.php
e204c4d 
Added default value to `$actionSegment`.
@Anubarak Anubarak merged commit a4e320e into Anubarak:master Jan 6, 2020
@Anubarak
Copy link
Owner

Anubarak commented Jan 6, 2020

Thank you, I'll create a new release tomorrow

@bencroker
Copy link
Contributor Author

Thanks Robin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bencroker @Anubarak