Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Floating-point calculation in provision.sh #248

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

AlpacaMax
Copy link
Collaborator

Line 24 in k8s/debug/provision.sh will not work in bash as bash does not support floating-point calculations. I changed that line and now the calculation is done using bc.

@wabscale
Copy link
Collaborator

What platform are you on where you spotted this issue? I haven't seen this come up on archlinux, MacOS and WSL.

@AlpacaMax
Copy link
Collaborator Author

It comes up on Ubuntu with bash version 5.0

@wabscale
Copy link
Collaborator

Ubuntu 18.04 or 20.04? Im just going to give this a try on different platforms before merging.

@AlpacaMax
Copy link
Collaborator Author

Pretty sure it's 20.04

@wabscale
Copy link
Collaborator

wabscale commented Sep 17, 2021

Platform Checks

  • Arch Linux
  • Ubuntu 20.04
  • MacOS
  • WSL

@wabscale
Copy link
Collaborator

Hmm ok, I'm seeing it calculate 15.50000000000000000000Gi on a 32 GiB system. I mean it is taking that number, but I don't think that is what we want. What are the memory resources on the machine you saw an issue on @AlpacaMax ?

@AlpacaMax
Copy link
Collaborator Author

So I saw this issue on a virtual machine with 4GB memory (it shows 3.8GiB in free -h). As a result it will try to compute 3.8 / 2, which gives me an error. After changing it to the version I wrote the calculation succeeded. Then minikube tells me my machine doesn't have enough resource for itself to run.

@wabscale
Copy link
Collaborator

Yeah unfortunately minikube debugging requires quite a bit of resources to work. Sometime soon we may be creating a debug cluster that we can get you access to. We'll still merge once I can confirm it works on all the main things.

@wabscale wabscale merged commit 5ff4e29 into AnubisLMS:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants