ADD Black and isort #292
Merged
ADD Black and isort #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates the python requirements for development from production using .in files. We can now use `make requirements` to generate the .txt requirements from the .in files. This prepares for the addition of mypy to the project.
Line length is set to 120.
|
Can you also add the instructions of using these linters into |
|
Thanks for the linting stuff. The one thing I would like you to remove is the linting check in the github action. I dont think we should consider tests as failed just because there is a linting issue. |
Done |
wabscale
approved these changes
Nov 7, 2021
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 7, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 7, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 7, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 23, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 23, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 23, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Nov 27, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 13, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 13, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 18, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 18, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 18, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 25, 2021
isort was accidentally removed in AnubisLMS#292
PIG208
added a commit
to PIG208/Anubis
that referenced
this pull request
Dec 25, 2021
isort was accidentally removed in AnubisLMS#292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts some dependencies-related changes from #283, configures black and isort, reformats files under
/api, and adds lint checks to GitHub Actions.