ADD Web Linting #307
Merged
ADD Web Linting #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as14692
changed the title
synoet
reviewed
Nov 12, 2021
web/package.json
Outdated
| @@ -40,6 +40,7 @@ | |||
| "proxy": "http://localhost:5000/", | |||
| "scripts": { | |||
| "start": "react-scripts start", | |||
| "lint": "yarn esw -w --fix --ext .jsx .", | |||
There was a problem hiding this comment.
replace with non fix linter, also ad .js to patterns
synoet
reviewed
Nov 12, 2021
web/Makefile
Outdated
| yarn run start & yarn run lint |
synoet
reviewed
Nov 12, 2021
.gitignore
Outdated
| @@ -8,6 +8,7 @@ os-dump-*.sql | |||
| .backups | |||
| .backups.* | |||
| .ipynb_checkpoints | |||
| /node_modules | |||
synoet
reviewed
Nov 12, 2021
web/package.json
Outdated
| @@ -67,6 +68,7 @@ | |||
| "eslint-plugin-import": "^2.22.1", | |||
| "eslint-plugin-node": "^11.1.0", | |||
| "eslint-plugin-promise": "^4.2.1", | |||
| "eslint-plugin-react": "^7.22.0" | |||
| "eslint-plugin-react": "^7.22.0", | |||
| "eslint-watch": "^8.0.0" | |||
synoet
reviewed
Nov 12, 2021
web/src/setupProxy.js
Outdated
| @@ -1,12 +1,12 @@ | |||
| const { createProxyMiddleware } = require('http-proxy-middleware'); | |||
| const {createProxyMiddleware} = require('http-proxy-middleware'); | |||
There was a problem hiding this comment.
revert changes you made to this file.
synoet
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using libraries husky and lint-staged for pre-commit hooks. Runs
eslint --fixon staged jsx,js files and commits when the commandgit commitis executed.