FIX diff to generate the correct context for short inputs and append newlines to the output #333

PIG208 · 2022-01-26T20:05:16Z

This fixes the following bugs:

When a mismatch occurs and one input is shorter than another, the remaining lines in the longer input will be discarded while the context might not have reached the desired number of lines (having 1 line instead of 5 for example).
Newlines are not added to the output generated.
Fix the confusion between the expected and actual output (the tooltip showed Actual / Expected while the expected output appears in the left)

It also removes an unused log message.

PIG208 · 2022-01-26T21:57:18Z

The actual and expected lines should appear on the different sides. This happens because of the lack of newlines.

To run the tests for cli, cd into the cli folder, install the requirements into the venv with `pip install requirements.txt`, then run `pytest` directly.

PIG208 force-pushed the diff-fix branch from 1f9cede to 1bc02a4 Compare January 26, 2022 22:30

PIG208 added 5 commits January 26, 2022 17:34

FIX normalize newlines in diff

4fde816

FIX prevent generating insufficient context in diff

9f28b60

RM unused log message

6ba05a3

FIX confusion between the expected and actual outputs

81a1942

FIX diff for empty lines

0861eb8

PIG208 force-pushed the diff-fix branch from 1bc02a4 to 0861eb8 Compare January 26, 2022 22:36

FIX module resolution when running tests

fc6d867

To run the tests for cli, cd into the cli folder, install the requirements into the venv with `pip install requirements.txt`, then run `pytest` directly.

wabscale merged commit fc6d867 into AnubisLMS:master Jan 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX diff to generate the correct context for short inputs and append newlines to the output #333

FIX diff to generate the correct context for short inputs and append newlines to the output #333

PIG208 commented Jan 26, 2022 •

edited

PIG208 commented Jan 26, 2022 •

edited

FIX diff to generate the correct context for short inputs and append newlines to the output #333

FIX diff to generate the correct context for short inputs and append newlines to the output #333

Conversation

PIG208 commented Jan 26, 2022 • edited

PIG208 commented Jan 26, 2022 • edited

PIG208 commented Jan 26, 2022 •

edited

PIG208 commented Jan 26, 2022 •

edited