Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHG use longer context for the diff produced #334

Merged
merged 5 commits into from
Feb 4, 2022
Merged

CHG use longer context for the diff produced #334

merged 5 commits into from
Feb 4, 2022

Conversation

PIG208
Copy link
Contributor

@PIG208 PIG208 commented Feb 1, 2022

  • Increases the default context length (so the students can see a fuller diff in most cases)
  • Avoid using a wrapper function in the loop for better performance

@wabscale
Copy link
Collaborator

wabscale commented Feb 2, 2022

Think you can add something to the seed so that some of the failed tests will reach a long context length?

@wabscale wabscale self-requested a review February 2, 2022 01:00
@wabscale wabscale added backend feature New feature or request labels Feb 2, 2022
@PIG208
CHG increase default context length
07ecb32
@PIG208
CHG optimize string preprocessing for diff computation
330b741 
For long identical inputs, calling `preprocess_func` instead of
`strip()` and `lower()` on the strings adds an overhead as this
function is called many times. This roughly reduces the worst case
runtime by roughly 50%.
@PIG208
Copy link
Contributor Author

PIG208 commented Feb 2, 2022

Think you can add something to the seed so that some of the failed tests will reach a long context length?

OK, updated in 07ecb32

@PIG208
Copy link
Contributor Author

PIG208 commented Feb 2, 2022

Oh sorry I misread that, will add it to the seed.

@PIG208
Copy link
Contributor Author

PIG208 commented Feb 2, 2022

Seed updated in b3d7a06

@wabscale
Copy link
Collaborator

wabscale commented Feb 4, 2022

Is this good to go?

@PIG208
Copy link
Contributor Author

PIG208 commented Feb 4, 2022

Yes

@PIG208 PIG208 force-pushed the diff-optimization branch 3 times, most recently from db60bcb to 42ab792 Compare February 4, 2022 20:47
@PIG208 PIG208 merged commit 4316ac1 into AnubisLMS:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wabscale wabscale Awaiting requested review from wabscale

Assignees

@PIG208 PIG208

Labels
backend feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PIG208 @wabscale