Better Item Selection UI

[MEEPofFaith]

Edit: Here, have a demonstration video conveniently placed at the top so that you don't need to scroll down through the commits and comments.

Finalized.Selection.UI.Improvements.mp4

---

Due to the sheer amount of things you can select (especially with mods installed), I decided to make the Payload Source's selection UI wider.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

• I have read the contribution guidelines.
• I have ensured that my code compiles, if applicable.
• I have ensured that any new features in this PR function correctly in-game, if applicable.

[MEEPofFaith]

Smaller UIs not affected.

sJ7V75Hphh.mp4

[MEEPofFaith]

I found that each row was 53 1/3 tall, and used that in the row calculations.

[sk7725]

test it in non-100% ui scaling

[USMP-lancer]

test it in non-100% ui scaling

yes

[MEEPofFaith]

Good point, I play on 75% UI scale, dunno about other scales

[MEEPofFaith]

aaa this is uncomfortable

[MEEPofFaith]

uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

Yea I'll make "8 rows" be based off of 100%

[MEEPofFaith]

Ok, made the rows based on 100% UI scaling so that it's correct.

iGWi6WFELk.mp4

I am uncomfortable with how large everything is.

[USMP-lancer]

I am uncomfortable with how large everything is.
reverse compensation

[MEEPofFaith]

This footage is in 100% UI scale.

Search.Bar.mp4

Mods active to bloat the amount of possible selections:

• BetaMindy
• Exotic Mod
• Exogenesis
• Endless Rusting
• Progressed Materials

[MEEPofFaith]

Now to fix it in other UI scales...

(This is 25%)

[MEEPofFaith]

Why didn't this exist before?

Tooltips.mp4

(Also I'm back down to a comfortable 75% UI scale)

[MEEPofFaith]

Made the displayed images larger so that there's some more detail (especially on really large sprites) and easier to actually highlight over the image to make the name tooltip appear.

Larger.Icons.mp4

[MEEPofFaith]

Now to fix it in other UI scales...

(This is 25%)

The width of the text box doesn't change with the scaling, and I don't know how to make it do that.

[buthed010203]

I tried to make it work with scaling and gave up, im convinced its impossible.
What you can try tho is setting the width to Scl.scl(40 * columns), it works ok but isnt perfect

[MEEPofFaith]

[buthed010203]

Why is rebuild a Runnable[] of length 1 rather than just Runnable rebuild = ...? both approaches work the same

[MEEPofFaith]

Why is rebuild a Runnable[] of length 1 rather than just Runnable rebuild = ...? both approaches work the same

unsure, but the attribute stats on AttributeCrafter use a single term array as well

[MEEPofFaith]

Now changing the ui scale doesn't change the number of rows visible at once

[MEEPofFaith]

25% is so tiny why does it exist

[MEEPofFaith]

Merge when

[buthed010203]

No
might want to ping anuke considering he gave feedback thats since been implemented

[MEEPofFaith]

No
might want to ping anuke considering he gave feedback thats since been implemented

Well I did post in pulls and Anuke has talked about it.

[buthed010203]

Ah ok

[MEEPofFaith]

Anything missing that I should add to this?
I'm too lazy to scroll down and look for stuff

[sk7725]

Anything missing that I should add to this? I'm too lazy to scroll down and look for stuff

Maybe set the threshold to 1.5x the scrollpane (ceil it), not just the x1 the scrollpane height;
e.g. for item selection pane (height = 5), the search bat would show up if you have more than 8 rows of items (5 * 1.5 ceil = 8).

[MEEPofFaith]

makes sense, you don't need to scroll a lot

[USMP-lancer]

id say is nice

[MEEPofFaith]

please no more

[MEEPofFaith]

oh no issues

[MEEPofFaith]

I swear to god if this has private branch conflicts.

[buthed010203]

I will end up merging them when v7 comes out either way

[BalaM314]

why is this not merged the payload source ui is so awkward

[Eclipse-04]

this is a 6 month post wha-

[MEEPofFaith]

I am surprised there are no merge conflicts

[buthed010203]

I am surprised there are no merge conflicts

just wait for the private branch

[Anuken]

I could try merging this soon, I haven't modified the selection UI at all.

[buthed010203]

I've merged this into my client and it seems to work well. For some reason the selection background gets really dark sometimes but thats probably just my doing

[Anuken]

Merged with a bunch of tweaks.

[MEEPofFaith]

epic