getDocumentByIdentifierWithInfo function and test

lib/utility/get-document-by-identifier-with-info.js

@@ -0,0 +1,32 @@
+'use strict';
+
+var async = require('async');
+
+/**
+ * Fetch the document, with keys `document_type` and `provider` populated
+ * @param {String} The identifier of the document to get
+ * @param {Function} cb(err, document)
+ */
+module.exports = function getDocumentWithInfoByIdentifier(identifier, finalCb) {
+  var documentUri = '/documents/identifier/' + identifier;
+  var pages = {
+    '/document_types': {},
+    '/providers': {}
+  };
+  pages[documentUri] = {};
+
+  var self = this;
+  async.waterfall([
+    function makeBatchCall(cb) {
+      self.batch(pages, cb);
+    },
+
+    function handleResults(res, cb) {
+      var doc = res.body[documentUri];
+      doc.provider = res.body['/providers'][doc.provider];
+      doc.document_type = res.body['/document_types'][doc.document_type];
+
+      cb(null, doc);
+    }
+  ], finalCb);
+};

lib/utility/get-document-with-info.js

@@ -9,7 +9,6 @@ var isMongoId = require('../helpers/is-mongo-id.js');
  * @param {String} The id of the document to get. Must be a valid MongoDB ObjectId
  * @param {Function} cb(err, document)
  */
-// TODO: same function by `identifier`
 module.exports = function getDocumentWithInfo(id, finalCb) {
   if(!id || !isMongoId(id)) {
     return finalCb(new Error('Argument error: the first argument must be a valid MongoDB ObjectId'));

test/helpers.js

@@ -44,6 +44,19 @@ describe('<High-level helper functions>', function() {
       });
     });
 
+    it('same thing by identifier', function(done) {
+      var identifier = configuration.test.fakeDocument.identifier;
+      anyfetch.getDocumentByIdentifierWithInfo(identifier, function(err, doc) {
+        should(err).not.be.ok;
+        should(doc).be.ok;
+        doc.should.have.properties('id', 'identifier', 'provider', 'document_type');
+        doc.provider.should.have.properties('client', 'name', 'document_count');
+        doc.document_type.should.have.properties('id', 'name', 'templates');
+
+        done();
+      });
+    });
+
     after(function(done) {
       anyfetch.deleteDocumentById(documentId, done);
     });