Order of compilation affects error message; microsoft/TypeScript#33143

AnyhowStep · Aug 29, 2019 · 67374c1 · AnyhowStep · Sep 4, 2019 · AnyhowStep
1 parent dcfcdd6
commit 67374c1
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 11 deletions.
diff --git a/test/compile-time/expected-output/query/having/nullable-where-clause-not-allowed.d.ts b/test/compile-time/expected-output/query/having/nullable-where-clause-not-allowed.d.ts
@@ -0,0 +1,16 @@
+import * as tsql from "../../../../../dist";
+/**
+ * https://github.com/microsoft/TypeScript/issues/33143
+ *
+ * Seems like adding this test changes the error message of the `WHERE` clause test.
+ */
+export declare const query: tsql.Query<{
+    fromClause: tsql.IFromClause<{
+        outerQueryJoins: undefined;
+        currentJoins: undefined;
+    }>;
+    selectClause: undefined;
+    limitClause: undefined;
+    unionClause: undefined;
+    unionLimitClause: undefined;
+}>;
diff --git a/test/compile-time/expected-output/query/having/nullable-where-clause-not-allowed.ts.errors b/test/compile-time/expected-output/query/having/nullable-where-clause-not-allowed.ts.errors
@@ -0,0 +1,33 @@
+[
+  {
+    "messageText": {
+      "messageText": "Type 'ExprImpl<Mapper<unknown, boolean | null>, IUsedRef<{}>>' is not assignable to type 'IExpr<{ mapper: Mapper<unknown, boolean>; usedRef: IUsedRef<{}>; }>'.",
+      "category": 1,
+      "code": 2322,
+      "next": {
+        "messageText": "Types of property 'mapper' are incompatible.",
+        "category": 1,
+        "code": 2326,
+        "next": {
+          "messageText": "Type 'Mapper<unknown, boolean | null>' is not assignable to type 'Mapper<unknown, boolean>'.",
+          "category": 1,
+          "code": 2322,
+          "next": {
+            "messageText": "Type 'boolean | null' is not assignable to type 'boolean'.",
+            "category": 1,
+            "code": 2322,
+            "next": {
+              "messageText": "Type 'null' is not assignable to type 'boolean'.",
+              "category": 1,
+              "code": 2322
+            }
+          }
+        }
+      }
+    },
+    "code": 2322,
+    "category": 1,
+    "length": 44,
+    "start": 266
+  }
+]
diff --git a/test/compile-time/expected-output/query/where/nullable-where-clause-not-allowed.ts.errors b/test/compile-time/expected-output/query/where/nullable-where-clause-not-allowed.ts.errors
@@ -11,17 +11,7 @@
         "next": {
           "messageText": "Type 'Mapper<unknown, boolean | null>' is not assignable to type 'Mapper<unknown, boolean>'.",
           "category": 1,
-          "code": 2322,
-          "next": {
-            "messageText": "Type 'boolean | null' is not assignable to type 'boolean'.",
-            "category": 1,
-            "code": 2322,
-            "next": {
-              "messageText": "Type 'null' is not assignable to type 'boolean'.",
-              "category": 1,
-              "code": 2322
-            }
-          }
+          "code": 2322
         }
       }
     },

diff --git a/...nullable-where-clause-not-allowed.ts.todo → ...ving/nullable-where-clause-not-allowed.ts b/...nullable-where-clause-not-allowed.ts.todo → ...ving/nullable-where-clause-not-allowed.ts
@@ -1,5 +1,10 @@
 import * as tsql from "../../../../../dist";
 
+/**
+ * https://github.com/microsoft/TypeScript/issues/33143
+ *
+ * Seems like adding this test changes the error message of the `WHERE` clause test.
+ */
 export const query = tsql.QueryUtil.newInstance()
     .having(() => tsql.and3(
         null,