Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Added the Closed/Open Source label #109

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Added the Closed/Open Source label #109

wants to merge 15 commits into from

Conversation

DrAGoniPenguin
Copy link
Contributor

Description

What did you add? or change?
I added the Closed/Open Source label.
This was started on 9/16, and I haven't seen any new pulls so...
I added a "template thingie" that you can remove since it's sort of dumb.
Probably not gonna be merged because my work is kinda dumb, but this was to address #107

Checklist

  • [ yeah ] My contributions follows the style guidelines of this project
  • [ uh huh] I have performed a self-review of my own contributions (checked for spelling errors, proper linking, etc)
  • [ mmmm ] I have run linting on my branch before submitting the PR

DrAGoniPenguin and others added 10 commits September 11, 2021 17:49
@DrAGoniPenguin
Update server_software.md
fe6c1b9 
Added Reliable and KSpigot.
I know you guys have like a dozen kb jars, but why not?
@DrAGoniPenguin
Merge pull request #1 from DrAGoniPenguin/Update-server_software.md
33e7102 
Update server_software.md
@JustDoom
Apply suggestions from code review
e2d90f2
@JustDoom
Apply suggestions from code review
b850bae
@JustDoom
Update server_software.md
3db01ce
@DrAGoniPenguin
Update server_software.md
47d13a4 
This was a stupid pain to make :(
I did the softwares down to the Modded Server Jars area.
@DrAGoniPenguin
Update server_software.md
ee18223 
testing new lines because clearly something was screwed up
@DrAGoniPenguin
Update server_software.md
8428338 
making sure i dont waste my time
@DrAGoniPenguin
Update server_software.md
7a60e65 
Did some more stuff lol
Note 2 self: Go to Plugins and mods to finish the ones school wifi blocks
@DrAGoniPenguin
Update server_software.md
e6f4d63 
Finished finally lol
@DrAGoniPenguin
Copy link
Contributor Author

I might have screwed up somewhere so I might have to recheck this stuff.

@JustDoom
Copy link
Collaborator

I think its a good idea
Just have some file conflicts atm

@Kruemmelspalter Kruemmelspalter added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2021
@DrAGoniPenguin
Update server_software.md
7c10ab7 
did what Kruemmelspalter requested
Hopefully this is what they meant
@DrAGoniPenguin
Update server_software.md
2efcabc 
idk if im doing this right
@DrAGoniPenguin
Update hosting_providers.md
402d995 
added some more hosts
surprised people haven't added them yet.
Not sure if they're reputable though, but I was just going off of google and spigotmc.
Plan to add a sorter if they have a free plan, free trial, or paid plan.
Also might add a trustpilot rating and stuff idk.
@DrAGoniPenguin
Update hosting_providers.md
23efa19 
im lazy and forgor to finish this 
wait a sec
@Kruemmelspalter
Copy link
Contributor

Do you mean RAM GB? Or Transfer GB? Maybe write what price/GB is meant

@DrAGoniPenguin
Copy link
Contributor Author

Yeah I meant RAM GB.
I accidentally closed out when I was working on it and it didn't save lmao so I'm starting over.
I'll have to revise it to make more sense I guess.
I didn't even know that it was synced to this other thing tbh .

@Kruemmelspalter
Copy link
Contributor

I think this is ready for merging if you resolve the conflicts (probably accept main changes in hosting_providers.md and accept your changes in server_software.md

@DrAGoniPenguin
Copy link
Contributor Author

DrAGoniPenguin commented Oct 24, 2021 •
edited
Loading

Sorry about the delay, I haven't been online lately (school) so yeah.
I also don't know much about github because I don't usually upload projects here and I just lurk around mostly.
I'm trying to find the main changes accepty thingie right now.
There's this massive biology project which made me completely forget about this

@Lezurex
Copy link
Contributor

Lezurex commented Dec 15, 2021

@DrAGoniPenguin You have to click the Fetch upstream button in your forked repository:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kruemmelspalter Kruemmelspalter Kruemmelspalter approved these changes

@JustDoom JustDoom Awaiting requested review from JustDoom JustDoom is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DrAGoniPenguin @JustDoom @Kruemmelspalter @Lezurex