helper exec fixes

[vr5]

No description provided.

[TheAio]

Before using these fixes i had the same problem as #2 , but now i get a buffer overflow error.

Here's my log;
sudo ./slmodemd/slmodemd -d9 -e ./d-modem SmartLink Soft Modem: version 2.9.11 Jun 1 2022 14:48:23 <198.024952> SmartLink Soft Modem: version 2.9.11 Jun 1 2022 14:48:23 <198.024962> slamr0: startup modem... <198.025030> slamr0: update termios... symbolic link /dev/ttySL0' -> /dev/pts/3' created. modem slamr0' created. TTY is /dev/pts/3' <198.025162> open file: /var/lib/slmodem/data.slamr0... <198.025170> cannot open '/var/lib/slmodem/data.slamr0': No such file or directory <198.025741> main: rt applyed: SCHED_FIFO, pri 99 <198.025815> main: dropped privileges to 65534.65534 Use /dev/ttySL0' as modem device, Ctrl+C for termination.
<202.510291> main: termios changed.
<202.510303> slamr0: update termios...
<203.744501> slamr0: run cmd: at
<203.744514> slamr0: modem report result: 0 (OK)
<233.659853> slamr0: run cmd: atd!6845102
<233.659875> slamr0: modem dial: !6845102...
<233.659883> slamr0: modem_dial_start...
<233.659891> call: create...
<233.659902> CallProgFP_Create >>
<233.659936> APPLY_FILTER = 0
<233.659945> Detection Thresholds: levle_fix=43,--> LEVEL_THRESHOLD=96
<233.659949> ============> 6
<233.659953> Cadence: Busy Tone loose detection is 0
<233.659957> TYPE BUSY
<233.659961> Filter index 6
<233.659964> Filter SubIndex 0
<233.659967> MAX_ON_TIME 30 Buffers MIN_ON_TIME 9 Buffers
<233.659970> MAX_OFF_TIME 30 Buffers MIN_OFF_TIME 9 Buffers
<233.659974> OFF_TIME_THAT_RESETS_CYCLE 90
<233.659977> BUFFER LENGTH 160 samples.
<233.659982> INTEGRATION_LENGTH 0[ms]
<233.659985> LEVEL 96
<233.659993> INTEGRATION_TIME = 0 Buffers.
<233.659998> Detection Thresholds: levle_fix=43,--> LEVEL_THRESHOLD=96
<233.660003> TYPE DIAL
<233.660007> Filter index 5
<233.660010> Filter SubIndex 0
<233.660013> MAX_ON_TIME 0 Buffers MIN_ON_TIME 0 Buffers
<233.660017> MAX_OFF_TIME 0 Buffers MIN_OFF_TIME 0 Buffers
<233.660021> OFF_TIME_THAT_RESETS_CYCLE 0
<233.660024> BUFFER LENGTH 666 samples.
<233.660028> INTEGRATION_LENGTH 2500[ms]
<233.660032> LEVEL 96
<233.660038> INTEGRATION_TIME = 28 Buffers.
<233.660043> CALLPROG Create <<
<233.660047> CALLPROG Dialing
<233.660052> Configuration->tone_DigitLength 100
<233.660057> Configuration->pulse_OffHookTime 36
<233.660059> Configuration->pulse_OnHookTime 64
<233.660062> Configuration->dialPauseTime 2
<233.660065> Configuration->flashTime 50
<233.660070> Configuration->toneOrPulseFlag 0
<233.660075> Configuration->dialModifierValidationFlag 0
<233.660078> Configuration->ABCD_PermittedFlag 0
<233.660082> Configuration->pulseAndToneInSameStringPermittedFlag 0
<233.660085> Configuration->callingToneFlag 0
<233.660087> Configuration->commaPauseDurLimit 255
<233.660091> Configuration->digitPattern 1
<233.660094> Configuration->tone_BetweenDigitsInterval 100
<233.660098> Configuration->pulse_BetweenDigitsInterval 800
<233.660102> DTMF_Gain1 = 13014
<233.660107> DTMF_Gain2 = 16384
<233.660110> AnalyzeDialString: Updated 17 May 1999 00:50
<233.660114> Dial String Syntax is VALID
<233.660119> GetNoAnswerTimeOut. 60
<233.660123> WAIT DIAL TIMEOUT = 5
<233.660127> CALLPROG_Dial was exited.
<233.660131> call: create RC: 9600 <-> 8000...
<233.660137> slamr0: modem_start..
<233.660141> slamr0: modem set state: 1 --> 2...
<233.660145> slamr0: new state: DP_ESTAB
<233.660149> main: socket_ioctl: cmd 8, arg 3...
<233.660153> slamr0: modem set hook: 0 --> 1...
<233.660158> main: socket_ioctl: cmd 2, arg 1...
<233.660162> main: socket_ioctl: returning 0
<233.660168> main: socket_ioctl: cmd 11, arg 0...
<233.660172> main: socket_ioctl: returning 4
<233.660190> main: socket_ioctl: cmd 4, arg 2580...
<233.660193> main: socket_ioctl: returning 0
<233.660197> main: socket_ioctl: cmd 7, arg 30...
<233.660201> main: socket_ioctl: returning 0
<233.660205> main: socket_start...
<233.660325> main: done delay thing
<233.661551> main: lost connection to child socket process
<233.661561> slamr0: modem_hup...2
<233.661565> slamr0: modem set state: 2 --> 9...
<233.661568> slamr0: new state: DP_DISC
<233.661573> slamr0: modem_stop..
<233.661577> main: socket_stop...
<233.661590> slamr0: modem set hook: 1 --> 0...
<233.661593> main: socket_ioctl: cmd 2, arg 0...
<233.661596> main: socket_ioctl: returning 0
<233.661598> main: socket_ioctl: cmd 8, arg 0...
<233.661604> call: delete...
<233.661607> Dialer was aborted.
<233.661609> CALLPROG_Delete is entered
<233.661612> cadence_delete with CADENCE_DIAL_OBJ is invoked
<233.661616> cadence_delete with CADENCE_OBJ is invoked
<233.661620> CALLPROG_Delete is exited
<233.661625> slamr0: modem set state: 9 --> 1...
<233.661629> slamr0: new state: MODEM_IDLE
<233.661632> slamr0: modem report result: 3 (NO CARRIER)
*** buffer overflow detected ***: terminated
Aborted
`

The error always occurs after the atd command, no matter what numbers i include or if i use ! or , in the same command.

[sonictruth]

This PR worked for me compared to the official repo.
Also I needed to trop the T from ATDTXXXXX.
Setting v32 worked also fine for me AT+MS=32,1,4800,14400