Add batch withdraw and natspec #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Jun 7, 2023
pandadefi
force-pushed
the
add_batch_withdraw
branch
from
098c124
to
0a57b84
Compare
fubuloubu
reviewed
Jun 7, 2023
fubuloubu
reviewed
Jun 7, 2023
pandadefi
force-pushed
the
add_batch_withdraw
branch
from
0a57b84
to
fb18951
Compare
fubuloubu
reviewed
Jun 7, 2023
fubuloubu
reviewed
Jun 7, 2023
pandadefi
force-pushed
the
add_batch_withdraw
branch
from
96838e2
to
c0fa54d
Compare
fubuloubu
reviewed
Jun 7, 2023
fubuloubu
reviewed
Jun 7, 2023
|
|
||
|
|
||
| @external | ||
| def batch_withdraw( |
There was a problem hiding this comment.
Might be more expedient to pass in token: ERC20 to this method, save the memory cost
There was a problem hiding this comment.
We still need to load the token on every iteration to asser the stream uses the same token
assert token.address == self.streams[creator][stream_id].token.address, "token must be the same for all streams"
There was a problem hiding this comment.
yep, but can save an SLOAD by passing it in as calldata
There was a problem hiding this comment.
And the SLOAD is more expensive than writing one more address on-chain?
There was a problem hiding this comment.
Oh, no no, I mean add it as an input argument
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
pandadefi
force-pushed
the
add_batch_withdraw
branch
from
fc9b04d
to
d882184
Compare
pandadefi
force-pushed
the
add_batch_withdraw
branch
from
23d8e10
to
9ab76af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.