This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
feat: adding set timestamp method to starknet provider #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
approved these changes
Jun 29, 2022
|
failing tests seem unrelated, will try to fix on other branch |
|
@unparalleled-js I'll need another approval I think, I just set up a pytest.skip for |
johnson2427
commented
Jun 30, 2022
| def test_set_timestamp(provider, account, contract): | ||
| start_time = provider.get_block("pending").timestamp | ||
| provider.set_timestamp(start_time + 8600) | ||
| contract.increase_balance(account.address, 123, sender=account) |
There was a problem hiding this comment.
Just stole this from a test above
antazoey
approved these changes
Jun 30, 2022
|
update on my side, been stuck all day on this bug causing the failing tests. I have realized that the starknet-devnet process works a lot better when run separately, likely the same issues preventing Foundry from working. (ApeWorX/ape-foundry#5) since it is the same base class. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added
set_timestampfor the starknet provider. Currently unable to hit the RPC endpoint for setting the timestamp of the blockfixes: #43
How I did it
Took similar methods from
ape-hardhatand used requests package to hit the localhost endpoint for now. This call is currently failing. Also added a test undertests.function.test_providerHow to verify it
Cannot do this yet
Checklist