Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check ape has connected to the intended network #1032

Closed
banteg opened this issue Sep 6, 2022 · 1 comment · Fixed by #1038
Closed

check ape has connected to the intended network #1032

banteg opened this issue Sep 6, 2022 · 1 comment · Fixed by #1038
Labels
category: bug Something isn't working

Comments

@banteg
Copy link
Contributor

banteg commented Sep 6, 2022

What went wrong?

similar to #1030, ape geth plugin should check it has indeed connected to the desired network and not just some network

Screen Shot 2022-09-06 at 20 06 34

How can it be fixed?

assert chain id matches the hardcoded value
@banteg banteg added the category: bug Something isn't working label Sep 6, 2022
@fubuloubu
Copy link
Member

suggested fix: detect if there is a mismatch during .connect()

@fubuloubu fubuloubu mentioned this issue Sep 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate Ape has connected to the right network and client fubuloubu/ape
2 participants
@fubuloubu @banteg