fix: validate Ape has connected to the right network and client

[fubuloubu]

What I did

Reorder how Web3Provider determines chain ID so that a fault is detected with mismatch of chain ID

fixes: #1030
fixes: #1032

How I did it

We have some validation already in place for chain ID, and this solves a corner case in the logic for validating that the correct network and client is connecting when a connection already exists.

How to verify it

1. Start anvil
2. ape console --network :mainnet (assumes geth is default)

Prior to change, (2) will work just fine, and fails after this change

Checklist

• All changes are completed
• New test cases have been added
• Documentation has been updated

[banteg]

i think this doesn't address the problem, we need to check that the associated chain id in the network spec matches the chain id from the provider we connected to. this needs to be done on connection to prevent user error of accidentally connecting to the wrong endpoint. such error could have dire results such as sending test transactions on live network or caching the wrong abis.

[antazoey]

i think this doesn't address the problem, we need to check that the associated chain id in the network spec matches the chain id from the provider we connected to. this needs to be done on connection to prevent user error of accidentally connecting to the wrong endpoint. such error could have dire results such as sending test transactions on live network or caching the wrong abis.

If you look at the connect method in ape-geth, you will see it already has logic for this, but the chain ID here was causing it not to work.

With these changes, if you do something like:

ape console --network ethereum:rinkeby:geth

and have a URI for mainnet in your config file, you will get this output (including the error):

INFO: Connecting to existing Erigon node at 'https://erigon.yearn.science/'.
ERROR: (ProviderError) HTTP Connection does not match expected chain ID. Are you connected to 'rinkeby'?

However, if you switch to main branch, this bug is still present. Wen you try the same thing, it allow you to connect to the console.

Thus, I think this PR fixes the bug. Or no??

[banteg]

checked this pr and confirmed it works for me

[banteg]

confirmed it works. maybe one suggestion is to also add numeric chain ids to the error.

INFO: Connecting to existing Erigon node at 'http://localhost:8545'.
ERROR: (ProviderError) HTTP Connection does not match expected chain ID. Are you connected to 'goerli'?

becomes

ERROR: (ProviderError) HTTP Connection chain ID (1) does not match expected chain ID (5). Are you connected to 'goerli'?

[ghost]

LGTM

[ghost]

🚀