Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker images need to be tested for running properly before pushing image to dockerhub #901

Closed
1 task
sabotagebeats opened this issue Jul 21, 2022 · 1 comment · Fixed by #1029
Closed
1 task
Assignees
Labels
category: testing Test plan for an existing feature

Comments

@sabotagebeats
Copy link
Contributor

sabotagebeats commented Jul 21, 2022

Elevator pitch:

ape docker image was failing when being ran and we were not able to know this because it was building fine. we should fix this.

Value:

prevents bad docker images from being pushed

Dependencies:

n/a

Design approach:

test docker image after building and make sure it runs successfully before pushing
detailed here: #891 (comment)

Task list:

  • Tasks go here

Estimated completion date:

Design review:

Do not signoff unless:

    1. agreed the tasks and design approach will achieve acceptance, and
    1. the work can be completed by one person within the SLA.
      Design reviewers should consider simpler approaches to achieve goals.

(Please leave a comment to sign off)

@sabotagebeats
Copy link
Contributor Author

related: #891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: testing Test plan for an existing feature
Projects
None yet
3 participants