feat: allow custom plugin specification in Docker file and other Docker / plugin improvements #1029
Conversation
antazoey
changed the title
antazoey
changed the title
antazoey
force-pushed
the
fix/jules/docker-typing-ext
branch
from
57652b6
to
cac84f5
Compare
| self.package_name = f"ape-{self.name}" # 'ape-plugin-name' | ||
| self.module_name = f"ape_{self.name.replace('-', '_')}" # 'ape_plugin_name' | ||
| self.current_version = get_package_version(self.package_name) | ||
| class PluginInstallRequest(BaseInterfaceModel): |
There was a problem hiding this comment.
The refactoring that got done is still really nice I think, even without it's primary drive.
|
|
||
| RUN pip install --upgrade pip \ | ||
| && pip install --no-cache-dir . \ | ||
| && pip install -r recommended-plugins.txt \ |
There was a problem hiding this comment.
The recommended plugins get installed via pip -r approach now.
The ape plugins install -r is not needed, as @fubuloubu pointed out that was not a good idea.
I am thinking this may not be the final implementation of this, but it is closer to what we want and achieves the goals.
| @@ -0,0 +1,12 @@ | |||
| ape-alchemy | |||
There was a problem hiding this comment.
This is shared between Dockerfile and setup.py
#456 says
Before this PR, there were times where if you ran |
Yes, you are right, that is a good idea. I created a new issue for this here: #1051 |
What I did
fixes: #901
fixes: #456
How I did it
How to verify it
Checklist