fix: issue with decoding None block hashes #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
johnson2427
approved these changes
Aug 19, 2022
| @@ -272,7 +272,7 @@ def decode_receipt(self, data: dict) -> ReceiptAPI: | |||
| return receipt | |||
|
|
|||
| def decode_block(self, data: Dict) -> BlockAPI: | |||
There was a problem hiding this comment.
Good find! Works for me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Regression from cache PR where could not decode pending blocks in
ape-hardhatHow I did it
Handle when hash is None in data when decoding block
How to verify it
Launch hardhat console
Get pending block
It should work
Checklist