fix: allow ecosystems to still load when default provider or network not found #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
fubuloubu
previously approved these changes
Sep 13, 2022
fubuloubu
approved these changes
Sep 13, 2022
sabotagebeats
approved these changes
Sep 13, 2022
antazoey
deleted the
fix/jules/allow-plugins-to-work-when-bad-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
If a provider plugin has a single bug in it currently, every core plugin that uses the
network_optionfails to load.This is because the config loads in the plugin attempting to set the default but the default provider "does not exist" but it fails to load.
How I did it
Instead of failing to return any ecosystems at all when attempting to set the default provider fails with a
NetworkError, log the error and move on.How to verify it
Checklist