feat: add supports_tracing() calculated property to ProviderAPI and Web3ProviderAPI
#1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Sep 22, 2022
fubuloubu
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It is nice to have a more convenient way to check if provider supports tracing. This helps me in my gas reporting efforts but I think will come in handy elsewhere, so opening it up separately.
How I did it
Check for
APINotImplementedErrorwhen callingget_call_tree(). If it fails with that, no tracing. Any other result indicates a tracing implementation.How to verify it
Launch console using various providers calling
provider.supports_tracingand making sure it is expected.Checklist