Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use minimal box #1070

Merged
merged 1 commit into from Sep 22, 2022
Merged

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Sep 22, 2022

What I did

Use minimal box type
So it'll look like this now:

                              SYMBOL Gas
                        ╷              ╷      ╷      ╷      ╷
  Method                │ Times called │ Min. │ Max. │ Mean │ Median
╶───────────────────────┼──────────────┼──────┼──────┼──────┼────────╴
  callContractCMethodC3 │ 1            │ 7977 │ 7977 │ 7977 │ 7977
                        ╵              ╵      ╵      ╵      ╵

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Contributor Author

antazoey commented Sep 22, 2022

For comparison:

Simple (was a suggestion):

                              SYMBOL Gas

  Method                  Times called   Min.   Max.   Mean   Median
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  callContractCMethodC3   1              7977   7977   7977   7977

Minimal (what this PR changes it to):

                              SYMBOL Gas
                        ╷              ╷      ╷      ╷      ╷
  Method                │ Times called │ Min. │ Max. │ Mean │ Median
╶───────────────────────┼──────────────┼──────┼──────┼──────┼────────╴
  callContractCMethodC3 │ 1            │ 7977 │ 7977 │ 7977 │ 7977
                        ╵              ╵      ╵      ╵      ╵

Heavy head (what it was before):

                              SYMBOL Gas
┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━┳━━━━━━┳━━━━━━━━┓
┃ Method                ┃ Times called ┃ Min. ┃ Max. ┃ Mean ┃ Median ┃
┡━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━╇━━━━━━╇━━━━━━━━┩
│ callContractCMethodC3 │ 1            │ 7977 │ 7977 │ 7977 │ 7977   │
└───────────────────────┴──────────────┴──────┴──────┴──────┴────────┘

@antazoey
Copy link
Contributor Author

@banteg

fubuloubu
fubuloubu previously approved these changes Sep 22, 2022
@antazoey antazoey merged commit 715167b into ApeWorX:main Sep 22, 2022
@antazoey antazoey deleted the feat/jules/use-simple-table branch September 22, 2022 18:52
@banteg
Copy link
Contributor

banteg commented Sep 22, 2022

still thinking the "simple" style would be superior, if you look at professionally typeset tables, none of them have vertical bars, it's a poor style popularized by ms excel. any article about how to make better tables would argue the same. for numeric columns it's better to align right so you can visually compare the difference magnitude. for decimal numbers it's best to align on the dot, but not sure rich supports it out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants