feat: automatically add --verbosity to scripts and other CLI fixes [APE-1091]
#1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
ape.cli namespaceape.cli namespace [APE-1091]
sabotagebeats
previously approved these changes
Jun 14, 2023
|
sabotagebeats
previously approved these changes
Jun 14, 2023
antazoey
force-pushed
the
feat/export-verbosity-option
branch
from
69d1635
to
19593a7
Compare
4 tasks
antazoey
force-pushed
the
feat/export-verbosity-option
branch
from
82f5ef8
to
f1a5162
Compare
antazoey
changed the title
ape.cli namespace [APE-1091]--verbosity to scripts and other CLI fixes [APE-1091]
sabotagebeats
previously approved these changes
Jun 14, 2023
|
ive got tests fixed locally but going to merge a few other PRs before pushing, fyi |
antazoey
force-pushed
the
feat/export-verbosity-option
branch
from
f1a5162
to
f9eb4fe
Compare
sabotagebeats
approved these changes
Jun 14, 2023
fubuloubu
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
from ape.cli.options import verbosity_options, you can dofrom ape.cli import verbosity_option.--verbosityoption tomainandclibased scriptsAttributeErrorfrom certain custom option classes not having an attribute named.nameverbosity_option()to work without passing in the logger as an argument--verbosityneeded for silverback ApeWorX/silverback#9
How I did it
How to verify it
Checklist