Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade dockerfile to python 3.10 [APE-1112] #1495

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

sabotagebeats
Copy link
Contributor

@sabotagebeats sabotagebeats commented Jun 19, 2023

What I did

upgrade dockerfile to python 3.10 by using python 3.10 slim base image

How I did it

wanted to have python 3.10 as base image so that using python 3.10

How to verify it

docker build -t ape .
docker run -it --entrypoint /bin/bash ape

harambe@09814ecfcd49:~/project$ python --version
Python 3.10.12

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title feat: upgrade dockerfile to python 3.10 feat: upgrade dockerfile to python 3.10 [APE-1112] Jun 19, 2023
@sabotagebeats sabotagebeats marked this pull request as ready for review June 19, 2023 22:12
@antazoey
Copy link
Contributor

Is this a breaking change for the image? Wondering if this should happen in 0.7 versus now.

Note, you can set PYTHON_ARG="3.10" in silverback if you need to

@sabotagebeats
Copy link
Contributor Author

this can wait for a later version if this is a breaking change, but it doesn't seem to break anything for me?

Is this a breaking change for the image? Wondering if this should happen in 0.7 versus now.

Note, you can set PYTHON_ARG="3.10" in silverback if you need to

@fubuloubu
Copy link
Member

Is this a breaking change for the image? Wondering if this should happen in 0.7 versus now.

Note, you can set PYTHON_ARG="3.10" in silverback if you need to

I agree with @antazoey, this could be a breaking change, and there's a workaround for now

@antazoey antazoey changed the title feat: upgrade dockerfile to python 3.10 [APE-1112] feat!: upgrade dockerfile to python 3.10 [APE-1112] Jun 21, 2023
@sabotagebeats
Copy link
Contributor Author

@antazoey should I close this or leave it open?

@fubuloubu
Copy link
Member

I think we should migrate everything that only used 3.8 to 3.10 when we migrate things for the v0.7.0 release (such as linting CI, base image, etc.)

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Aug 5, 2023
@fubuloubu fubuloubu removed the stale No activity for 30 days label Aug 5, 2023
@sabotagebeats
Copy link
Contributor Author

sabotagebeats commented Aug 17, 2023

I think this is now a blocker for chaosnet ApePay integration.

I tried using ARG PYTHON_VERSION="3.10" in silverback, but it does not work to accomplish the task.

#1495 (comment)

@fubuloubu fubuloubu enabled auto-merge (squash) August 17, 2023 20:10
@fubuloubu
Copy link
Member

Noting that this is breaking change for some, but hopefully impact is small

@fubuloubu fubuloubu merged commit d84e45e into ApeWorX:main Aug 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants