Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dockerfile for automated builds to dockerhub #165

Merged
merged 9 commits into from Oct 12, 2021
Merged

feat: Add dockerfile for automated builds to dockerhub #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bcb0cf7
feat: added dockerfile
sabotagebeats Sep 27, 2021
178d783
docs: added installing via docker and link to docker repo
sabotagebeats Sep 27, 2021
bd272bf
fix: moved dockerfile to Dockerfile
sabotagebeats Sep 28, 2021
303aad2
perf: pinned versions, removed python-is-python3, changed -y to --yes
sabotagebeats Sep 28, 2021
6b84583
feat: entrypoint
sabotagebeats Oct 6, 2021
a1266bb
fix: docker copy ape and build from .
sabotagebeats Oct 6, 2021
2b20137
perf: reduce layers, add dockerfile, build from ., add entrypoint
sabotagebeats Oct 7, 2021
0e1dd5e
ref: Merge remote-tracking branch 'upstream/main' into feat/docker
sabotagebeats Oct 8, 2021
ce23de6
chore: Merge remote-tracking branch 'upstream/main' into feat/docker
sabotagebeats Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .dockerignore
View file
Open in desktop
@@ -0,0 +1,3 @@
./tests
./docs
./.github
10 changes: 10 additions & 0 deletions Dockerfile
View file
Open in desktop
@@ -0,0 +1,10 @@
FROM ubuntu:20.04
RUN apt-get update && apt-get upgrade --yes && apt-get install git python3.8 python3-pip --yes
COPY . .
RUN python3 ./setup.py install
RUN ape plugins add solidity --yes
RUN ape plugins add vyper --yes
Copy link
Contributor

@antazoey antazoey Sep 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of CLI Dockerfiles I see use ENTRYPOINT so it is like running ape when you run the container, which means if you don't give it commands, it just prints the help and exits... I think you mentioned you looked into this pattern, but just thought I'd say that it is common from what I have seen. How much have we considered this approach?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is GETH example: https://github.com/islishude/geth-docker/blob/master/Dockerfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice it builds uses alpine, uses geth command as the entrypoint, and it builds from source!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used ENTRYPOINT before however I want to make sure that we can do other CLI stuff other than just running ape console for example ape accounts and ape compile etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be what ever command the user types in!

They would run the container with the same args that they run ape with. So if they run the container with console as the argument, it would launch a console, etc.

Copy link
Contributor

@antazoey antazoey Sep 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this docker run apeworx/ape console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be what ever command the user types in!
They would run the container with the same args that they run ape with. So if they run the container with console as the argument, it would launch a console, etc.

yes then the problem here then becomes that they can't do other things if they need to with the cli within that image, right?

RUN ape plugins add infura --yes
RUN ape plugins add etherscan --yes
RUN ape plugins add ens --yes
ENTRYPOINT ["ape"]
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -26,6 +26,10 @@ cd ape
python3 setup.py install
```

### via `docker`

Please visit our [Dockerhub](https://hub.docker.com/repository/docker/apeworx/ape) for more details on using Ape with Docker.

## Quick Usage

Ape is primarily meant to be used as a command line tool. Here are some things you can use ape to do:
Expand Down