fix: issue where parity style traces did not work in ape-geth provider #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
previously approved these changes
Jul 23, 2022
src/ape_geth/providers.py
Outdated
| traces = ParityTraceList.parse_obj(raw_trace_list) | ||
| response = self._make_request("trace_transaction", [txn_hash]) | ||
| if "error" in response: | ||
| raise ValueError(response["error"]["message"]) |
There was a problem hiding this comment.
Instead of ValueError, you could raise ProviderError
fubuloubu
previously approved these changes
Jul 23, 2022
antazoey
changed the title
antazoey
reviewed
Jul 25, 2022
|
|
||
| raw_trace_list = response.get("result", []) | ||
|
|
||
| if not raw_trace_list: |
There was a problem hiding this comment.
have to do this because I see weird things where some transactions have 0 trace and get_calltree_from_parity_trace expects at least one item in the result.
fubuloubu
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
chain.provider.get_call_treeshould work againChecklist