Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle more array situations #909

Merged
merged 2 commits into from Jul 23, 2022
Merged

fix: handle more array situations #909

merged 2 commits into from Jul 23, 2022

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Jul 23, 2022 •
edited

What I did

fixes: #905

How I did it

  • Adjust regex to handle arrays of size > 9
  • Add handling for when is unnamed tuple of arrays
  • Rename List to Array in some tests
  • Other small clean up

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Jul 23, 2022
View reviewed changes
@antazoey antazoey requested a review from fubuloubu July 23, 2022 17:54
@antazoey
Copy link
Contributor Author

@fubuloubu Just addressed some feedback from Discord after your approval

@antazoey antazoey enabled auto-merge (squash) July 23, 2022 18:00
@antazoey antazoey merged commit 7efa7c5 into ApeWorX:main Jul 23, 2022
@antazoey antazoey deleted the fix/jules/arrays branch July 23, 2022 18:09
antazoey added a commit to antazoey/ape that referenced this pull request Jul 23, 2022
@antazoey
fix: handle more array situations (ApeWorX#909)
1dd4c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ape cannot parse arrays properly
2 participants
@antazoey @fubuloubu