feat: add receipt / txn_hash to ContractInstance
#955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotPeopling2day
previously approved these changes
Aug 9, 2022
johnson2427
previously approved these changes
Aug 9, 2022
| @@ -92,11 +92,9 @@ def test_snapshot_and_restore_unknown_snapshot_id(chain): | |||
|
|
|||
| def test_snapshot_and_restore_no_snapshots(chain): | |||
| chain._snapshots = [] # Ensure empty (gets set in test setup) | |||
| with pytest.raises(ChainError) as err: | |||
| with pytest.raises(ChainError, match="There are no snapshots to revert to."): | |||
There was a problem hiding this comment.
I didn't know this existed, this is a really nice implementation
johnson2427
approved these changes
Aug 9, 2022
NotPeopling2day
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #806
txn_hashtoContractInstancethat gets set whenever possible, such as after deployments as well as if instantiating a contract that was previously deployed (using theinstance_at()method)..receipt()convenience property to theContractInstance. Now, after you deploy, you have access to the receipt pretty immediate.This is needed to unblock my work for publishing deployments but is also kind of nice to have anyway and I think exists in Brownie.
How I did it
txn_hasharguments tocontracts.instance_at()andcontract.at()transaction_hashkey to the deployments cachetxn_hashautomatically when calling.deploy()instance_at()try to look up thetxn_hashwhen it is not provided (if it was from a deployment)How to verify it
Make sure you can access the txn hash and receipt on a contract instance:
Checklist